fix: handle stream read error case by explicitly closing the substream #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-substream-tracing
branch
2 times, most recently
from
9cbdcc1 to
1b72d0c
Compare
stringhandler
changed the title
stringhandler
changed the title
- adds yamux stream id to logs to enrich rpc sesssion tracing info - handle stream read error case by explicitly closing the substream - updates rpc tests to use yamux
sdbondi
force-pushed
the
comms-substream-tracing
branch
from
1b72d0c to
477be5b
Compare
|
ignored broken doc test (now needs yamux setup, previously a only MemorySocket was required) |
stringhandler
approved these changes
Sep 8, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
tari-project#3321) Description --- - adds yamux stream id to logs to enrich rpc sesssion tracing info - handle stream read error case by explicitly closing the substream - updates rpc tests to use yamux Motivation and Context --- May allow us to diagnose where slowness in a RPC session/substream occurs How Has This Been Tested? --- Tests updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
May allow us to diagnose where slowness in a RPC session/substream occurs
How Has This Been Tested?
Tests updated